Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat.histogram2d update #1237

Merged
merged 1 commit into from Jan 5, 2019
Merged

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Jan 4, 2019

  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

Example

# from #965        
pa = plot(x=randn(1000), y=ones(1000), Geom.histogram2d(xbincount=20))
pb = plot(x=randn(1000), y=ones(1000), Scale.y_discrete, Geom.histogram2d(xbincount=20))
hstack(pa,pb)

histogram2d

@tlnagy
Copy link
Member

tlnagy commented Jan 4, 2019

Thanks for squashing all these old bugs 🎉

@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #1237 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
+ Coverage   85.45%   85.67%   +0.22%     
==========================================
  Files          35       35              
  Lines        4083     4085       +2     
==========================================
+ Hits         3489     3500      +11     
+ Misses        594      585       -9
Impacted Files Coverage Δ
src/bincount.jl 84.53% <100%> (+1.03%) ⬆️
src/statistics.jl 90.62% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991b6dd...b0f20aa. Read the comment docs.

@bjarthur bjarthur merged commit aa8dff9 into GiovineItalia:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inexact error for histogram2d InexactError
4 participants