feature/hvband

[CiaranOMara]

This feature provides Geom.hband and Geom.vband geometries that address a need similar to that expressed in #1174. This pull request revives #1176.

Contributor checklist:

• I've updated the documentation to reflect these changes
• I've added an entry to NEWS.md
• I've added and/or updated the unit tests
• I've run the regression tests
• I've squash'ed or fixup'ed junk commits with git-rebase
• I've built the docs and confirmed these changes don't cause new errors

Proposed changes

• Add Geom.hband geometry that has the same width properties of hline, but a vertical span specified by ymin and ymax.
• Add Geom.vband geometry that has the same height properties of vline, but a horizontal span specified by xmin and xmax.
• Allow elements of type Measure to pass through coord.jl and statistics.jl.

[codecov-io]

Codecov Report

Merging #1264 into master will increase coverage by 0.01%.
The diff coverage is 95.23%.

@@            Coverage Diff            @@
##           master   #1264      +/-   ##
=========================================
+ Coverage   90.59%   90.6%   +0.01%     
=========================================
  Files          37      38       +1     
  Lines        3945    3961      +16     
=========================================
+ Hits         3574    3589      +15     
- Misses        371     372       +1

Impacted Files	Coverage Δ
src/geometry.jl	75% <ø> (ø)	⬆️
src/coord.jl	91.39% <100%> (ø)	⬆️
src/geom/hvband.jl	100% <100%> (ø)
src/statistics.jl	96.88% <93.33%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e4c9a...cb916d1. Read the comment docs.

[CiaranOMara]

@bjarthur, @Mattriks, and @tlnagy, what were the issues with this PR?

[Mattriks]

I think the discussion about this was in #1176, and it looks like you didn't get back to this PR after splitting #1176. I think to finish this you just need to complete the checklist in you first post above. Have you redone the regression tests?

[CiaranOMara]

I was able to do the regression tests with @davidanthoff's Rsvg.jl PR. Somethings pertaining to histogram and hexbin came up, but I don't think they're related to changes here. Let me know if you would like me to post the Diffs here.

[bjarthur]

this will be nice to have! thanks for this. what was different in the regression tests?

[CiaranOMara]

These diffs appear to be due to minor variations in how the colours have rasterised. In my opinion, the newer version looks sharper.

colorful_hist

dodged_discrete_histogram_horizontal

dodged_discrete_histogram

hexbin_dark

hexbin

stacked_continuous_histogram

stacked_discrete_histogram

[bjarthur]

i've seen these minor differences often before too. not sure how to complain. have never held up a PR because of it.

thanks!