Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer aesthetic inheritance improvement #1463

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Jul 4, 2020

  • I've updated the documentation to reflect these changes
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

  • Geoms in layers can inherit aesthetics from the plot, if layer aesthetics are incomplete

Example:

using RDatasets
iris = dataset("datasets", "iris")
plot(iris, x=:SepalLength, y=:PetalLength,
    layer(Geom.smooth(method=:loess), color=["Smooth"]),
    layer(Geom.point, color=["Points"]),
    Scale.color_discrete_manual("black","deepskyblue")
)

iris_points_smooth

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2020

Codecov Report

Merging #1463 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1463   +/-   ##
=======================================
  Coverage   89.40%   89.41%           
=======================================
  Files          39       39           
  Lines        4399     4402    +3     
=======================================
+ Hits         3933     3936    +3     
  Misses        466      466           
Impacted Files Coverage Δ
src/Gadfly.jl 75.88% <100.00%> (+0.05%) ⬆️
src/geom/rectbin.jl 80.00% <100.00%> (ø)
src/statistics.jl 96.45% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c6666...49d8381. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants