Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent stackoverflow in color_discrete_manual, fixes #844 #886

Merged
merged 1 commit into from
Aug 28, 2016

Conversation

tlnagy
Copy link
Member

@tlnagy tlnagy commented Aug 27, 2016

Throws a MethodError if the correct color_discrete_manual function isn't found instead of crashing.

@coveralls
Copy link

coveralls commented Aug 27, 2016

Coverage Status

Coverage remained the same at 65.603% when pulling c40e791 on tlnagy:fix-color-manual-stackoverflow into f6183ac on dcjones:master.

@shashi shashi merged commit 30670b3 into GiovineItalia:master Aug 28, 2016
@tlnagy tlnagy deleted the fix-color-manual-stackoverflow branch August 29, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants