-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set __str__ to use name and id for Dataset and Model #1732
feat: set __str__ to use name and id for Dataset and Model #1732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, I only have one remark is that the type of object is not visible:
test-b55675f8-2ffd-4d7e-92b8-945e40be5b68
can be either a Model or a Dataset.
I believe something like that would be better:
<giskard.Model name="test" uuid=b55675f8-2ffd-4d7e-92b8-945e40be5b68>
I overloaded the |
@kevinmessiaen I have added utest for |
I don't have a strong opinion on it so we can go without it. But I'm not convinced by having |
Very good point let me update this request |
Description
Define
__str__
for the Dataset and Model classes for more user friendly prints and reportsRelated Issue
Original discussion
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.make codestyle
.