Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-1069] Add text transform: remove accents #1755

Merged
merged 6 commits into from Jan 26, 2024
Merged

[GSK-1069] Add text transform: remove accents #1755

merged 6 commits into from Jan 26, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2024

Description

I implemented TextAccentRemovalTransformation to remove accents with a perturbation rate that defaults to 1.0 (to remove all accents).

Note

For the test, I used the texts and expected results from the issue (#1741).
Let me know if you want me to use the rate to ensure it is working appropriately.

Related Issue

#1741

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@ghost ghost changed the title Add text transform to remove accents [GSK-1069] Add text transform: remove accents Jan 22, 2024
@ghost ghost marked this pull request as ready for review January 22, 2024 15:00
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I would just add an extra example in the test.

tests/scan/test_text_transformations.py Outdated Show resolved Hide resolved
@kevinmessiaen kevinmessiaen merged commit 782f295 into Giskard-AI:main Jan 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants