Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pre-commit #1761

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fixed pre-commit #1761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3184f79
Fixed pre-commit
kevinmessiaen Jan 23, 2024
610baf3
Merge branch 'main' into fix/pre-commit
Hartorn Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions giskard/core/suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
import traceback
from dataclasses import dataclass
from functools import singledispatchmethod

from xml.etree.ElementTree import Element, SubElement, tostring
from xml.dom import minidom
from xml.etree.ElementTree import Element, SubElement, tostring

from mlflow import MlflowClient

from giskard.client.dtos import SuiteInfo, SuiteTestDTO, TestInputDTO, TestSuiteDTO
from giskard.client.giskard_client import GiskardClient
from giskard.core.core import TestFunctionMeta
Expand Down Expand Up @@ -156,41 +157,51 @@ def to_wandb(self, run: Optional["wandb.wandb_sdk.wandb_run.Run"] = None) -> Non
) from e
run.log({"Test suite results/Test-Suite Results": wandb.Table(columns=columns, data=data)})


def to_junit(self):
"""Convert the test suite result to JUnit XML format."""
testsuites = Element('testsuites', {'tests': str(len(self.results))})
testsuites = Element("testsuites", {"tests": str(len(self.results))})

for test_tuple in self.results:
test_name, test, _ = test_tuple
testsuite = SubElement(testsuites, 'testsuite', {
'name': f"Test {test_name} (metric={test.metric})",
})
testcase = SubElement(testsuite, 'testcase', {'name': test.metric_name, 'time': str(test.metric)}) # replace with actual time
testsuite = SubElement(
testsuites,
"testsuite",
{
"name": f"Test {test_name} (metric={test.metric})",
},
)
testcase = SubElement(
testsuite, "testcase", {"name": test.metric_name, "time": str(test.metric)}
) # replace with actual time

if not test.passed:
failure = SubElement(testcase, 'failure', {
'message': f"Test failed with metric of {test.metric}",
'type': "TestFailed" if not test.is_error else "Error"
})
failure = SubElement(
testcase,
"failure",
{
"message": f"Test failed with metric of {test.metric}",
"type": "TestFailed" if not test.is_error else "Error",
},
)
# Add full test result information here
for k, v in test.__dict__.items():
if k != 'messages' and k != 'is_error':
SubElement(failure, 'detail', {'name': k, 'value': str(v)})
if k != "messages" and k != "is_error":
SubElement(failure, "detail", {"name": k, "value": str(v)})
for message in test.messages:
SubElement(failure, 'detail', {'name': 'message', 'value': message})
SubElement(failure, "detail", {"name": "message", "value": message})
else:
# Add test result information here
for k, v in test.__dict__.items():
if k != 'messages' and k != 'is_error':
SubElement(testcase, 'detail', {'name': k, 'value': str(v)})
if k != "messages" and k != "is_error":
SubElement(testcase, "detail", {"name": k, "value": str(v)})
for message in test.messages:
SubElement(testcase, 'detail', {'name': 'message', 'value': message})
SubElement(testcase, "detail", {"name": "message", "value": message})

# Convert to string
xml_str = minidom.parseString(tostring(testsuites)).toprettyxml(indent=" ")
return xml_str


class SuiteInput:
"""Represents an input parameter for a test suite.

Expand Down
Loading