-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching from mlWorkerId to kernel name #1777
Switching from mlWorkerId to kernel name #1777
Conversation
…feature/gsk-2722-making-the-kernel-actually-start-worker
…l-actually-start-worker
…l-actually-start-worker
…feature/gsk-2722-making-the-kernel-actually-start-worker
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I'm doing something wrong but I got this error:
GiskardError: Not Found: Python kernel not found by key: No Kernel found with name external_worker
I ran this piece of code:
from giskard import GiskardClient
url = "http://localhost:9000"
api_key = "gsk-..."
# Create a giskard client to communicate with Giskard
client = GiskardClient(url, api_key)
client.create_project('test', 'test', 'external_worker', 'Empty desc')
and the worker have external_worker
as kernel name:
""" | ||
# TODO(Bazire): handle properly the "auto" detection/creation of kernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I really think that we need an auto detection and creation of kernel for ease of use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that we can create/use the kernel with the project id as name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes either by a project id or some name generated like: {os_host}-{python_version}
If we find another kernel using the same name with different dependencies we just do {os_host}-{python_version}-{random-value}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general
""" | ||
# TODO(Bazire): handle properly the "auto" detection/creation of kernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that we can create/use the kernel with the project id as name?
Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.make codestyle
.