Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests run on enron #1789

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix tests run on enron #1789

merged 2 commits into from
Feb 2, 2024

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Feb 2, 2024

Description

TextNumberToWordTransformation was failing if row["language__gsk__meta"] was nan

Before : https://github.com/Giskard-AI/giskard/actions/runs/7750039265
After : https://github.com/Giskard-AI/giskard/actions/runs/7753720227

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

value = row[self.column]
lang = row["language__gsk__meta"]
if pd.isna(value) or pd.isna(lang):
return value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not pd.isna(value) and pd.isna(lang) I would still apply num2words without specifying lang (it would default to english).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the defaulting to en

@Hartorn Hartorn enabled auto-merge (squash) February 2, 2024 09:30
Copy link

sonarcloud bot commented Feb 2, 2024

@Hartorn Hartorn merged commit d1aa9ca into main Feb 2, 2024
16 checks passed
@Hartorn Hartorn deleted the fix-nightly-tests branch February 2, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants