-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-2892] Improve RAG toolset #1820
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall solid PR, but too much repeated used of string key in dict.
This could be improved by using dataclass/constant/formatting function
topics = [question["metadata"]["topic"] for question in question_evaluation] | ||
failure_palette = ["#ba0e0e", "#0a980a"] | ||
questions = [question["question"] for question in question_evaluation] | ||
agent_answer = [question["agent_answer"] for question in question_evaluation] | ||
reference_answer = [question["reference_answer"] for question in question_evaluation] | ||
correctness = [question["correctness"] for question in question_evaluation] | ||
colors = [failure_palette[question["correctness"]] for question in question_evaluation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of string defined here, aren't we missing constants here ?
No description provided.