Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSK-1807 Integrate Sentry #1823

Merged
merged 12 commits into from
Mar 5, 2024
Merged

GSK-1807 Integrate Sentry #1823

merged 12 commits into from
Mar 5, 2024

Conversation

kevinmessiaen
Copy link
Member

Description

Added Sentry integration in order to receive exception reports.

Only information coming from giskard, pandas and numpy are being sent

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Copy link

linear bot commented Feb 27, 2024

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested:

>>> import giskard
>>> division_by_zero = 1 / 0
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ZeroDivisionError: division by zero
image

@kevinmessiaen kevinmessiaen requested a review from a team as a code owner March 5, 2024 08:44
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.8% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@kevinmessiaen kevinmessiaen merged commit ea622cc into main Mar 5, 2024
15 of 16 checks passed
@kevinmessiaen kevinmessiaen deleted the GSK-1807 branch March 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants