GSK-2887 Upload tests with project when uploading a suite #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inokinoki
requested changes
Mar 7, 2024
| @@ -430,12 +430,10 @@ def head_slice(df: pd.DataFrame) -> pd.DataFrame: | |||
|
|
|||
|
|
|||
| # FIXME: Internal worker cannot yet load callable due to yaml deserialization issue | |||
| @@ -481,16 +479,14 @@ def do_nothing(row): | |||
|
|
|||
|
|
|||
| # FIXME: Internal worker cannot yet load callable due to yaml deserialization issue | |||
tests/test_artifact_download.py
Outdated
| @@ -149,17 +150,17 @@ def test_download_callable_function(cf: Artifact): | |||
| do_nothing, # Transformation | |||
| ], | |||
| ) | |||
| def test_download_global_callable_function_from_module(cf: Artifact): | |||
| def test_download_callable_function_from_module(cf: Artifact): | |||
| with MockedClient(mock_all=False) as (client, mr): | |||
| cf.meta.uuid = str(uuid.uuid4()) # Regenerate a UUID to ensure not loading from registry | |||
| cache_dir = get_local_cache_callable_artifact(artifact=cf) | |||
|
|
|||
| requested_urls = [] | |||
| # Prepare global URL | |||
There was a problem hiding this comment.
Can be changed to prepare URLs, cuz we have no more global artefacts
I've updated th PR and remove the optional client |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always send the
project_keywhen uploading/downloading tests