Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the llm client to reset when changing llm api or model #1842

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Mar 13, 2024

Description

Related Issue

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn requested a review from mattbit March 13, 2024 11:25
@Hartorn Hartorn self-assigned this Mar 13, 2024
@mattbit mattbit marked this pull request as ready for review March 13, 2024 11:30
@Hartorn Hartorn enabled auto-merge (squash) March 13, 2024 11:37
Copy link

sonarcloud bot commented Mar 14, 2024

@Hartorn Hartorn merged commit 5b067db into main Mar 14, 2024
16 checks passed
@Hartorn Hartorn deleted the hotfix-unset-llm_client branch March 14, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants