Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSK-2928 GSK-2877 Added a method to start and stop managed ML worker using the … #1851

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

kevinmessiaen
Copy link
Member

Description

  • Added start_managed_worker(kernel_name) to start the worker
  • Added stop_managed_worker(kernel_name) to stop the worker

Copy link

linear bot commented Mar 15, 2024

@kevinmessiaen kevinmessiaen requested review from Inokinoki and Hartorn and removed request for Inokinoki March 18, 2024 03:08
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I dropped my changes in cbd3632 to expose the similar methods to cli.
You can add them if you'd like

…rojects' into GSK-2928

# Conflicts:
#	giskard/client/giskard_client.py
@kevinmessiaen kevinmessiaen changed the title GSK-2928 Added a method to start and stop managed ML worker using the … GSK-2928 GSK-2877 Added a method to start and stop managed ML worker using the … Mar 20, 2024
Copy link

linear bot commented Mar 20, 2024

@kevinmessiaen kevinmessiaen merged commit a9b9dc6 into multi-ml-worker Mar 20, 2024
15 checks passed
@kevinmessiaen kevinmessiaen deleted the GSK-2928 branch March 20, 2024 09:28
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants