Prevent torch faulty version on MacOS #1855

Hartorn · 2024-03-19T09:36:10Z

Description

📚 Examples / docs / tutorials / dependencies update
🔧 Bug fix (non-breaking change which fixes an issue)
🥂 Improvement (non-breaking change which improves an existing feature)
🚀 New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to change)
🔐 Security fix

I've read the CODE_OF_CONDUCT.md document.
I've read the CONTRIBUTING.md guide.
I've written tests for all new methods and classes that I created.
I've written the docstring in Google format for all the methods and classes that I used.
I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
modified)

sonarcloud · 2024-03-19T12:47:33Z

rabah-khalek

working, let's just add torch to the llm group in pyproject.toml

Hartorn requested a review from mattbit March 19, 2024 09:36

Hartorn self-assigned this Mar 19, 2024

Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 19, 2024

github-actions bot removed the Lockfile Temporary label to update pdm.lock label Mar 19, 2024

Hartorn force-pushed the fix-torch-segfault branch from 4fb943c to e216634 Compare March 19, 2024 12:17

Hartorn marked this pull request as ready for review March 19, 2024 12:18

Hartorn requested a review from rabah-khalek March 19, 2024 12:18

Fix segfault from torch

2eea09b

Hartorn force-pushed the fix-torch-segfault branch from e216634 to 2eea09b Compare March 19, 2024 12:22

rabah-khalek approved these changes Mar 19, 2024

View reviewed changes

Hartorn merged commit c3b8075 into main Mar 19, 2024
16 checks passed

Hartorn deleted the fix-torch-segfault branch March 19, 2024 13:24