Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAG Toolkit: Out of KB questions [GSK-3372] #1861

Merged
merged 13 commits into from
Apr 8, 2024
Merged

RAG Toolkit: Out of KB questions [GSK-3372] #1861

merged 13 commits into from
Apr 8, 2024

Conversation

JiaenLiu
Copy link
Contributor

Description

First prototype of out of knowledge base question

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@JiaenLiu JiaenLiu requested a review from mattbit March 25, 2024 13:15
@JiaenLiu JiaenLiu self-assigned this Mar 25, 2024
@linear Linear
Copy link

linear bot commented Mar 25, 2024

GSK-3372 First prototype of out of knowledge base questions

mattbit
mattbit previously requested changes Mar 25, 2024
View reviewed changes
giskard/rag/metrics/__init__.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
tests/rag/test_question_generators.py Outdated Show resolved Hide resolved
giskard/rag/question_generators/ookb_questions.py Outdated Show resolved Hide resolved
@mattbit mattbit changed the title Task/out of kb questions gsk 3372 RAG Toolkit: Out of KB questions [GSK-3372] Mar 25, 2024
@JiaenLiu JiaenLiu requested a review from mattbit March 25, 2024 15:50
@JiaenLiu JiaenLiu requested a review from pierlj April 2, 2024 13:43
@JiaenLiu JiaenLiu enabled auto-merge April 4, 2024 14:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pierlj pierlj dismissed mattbit’s stale review April 8, 2024 13:40

Changes were adressed

@JiaenLiu JiaenLiu merged commit 3bea570 into main Apr 8, 2024
16 checks passed
@JiaenLiu JiaenLiu deleted the task/out-of-kb-questions-gsk-3372 branch April 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlj pierlj pierlj approved these changes

@mattbit mattbit Awaiting requested review from mattbit

Assignees

@JiaenLiu JiaenLiu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JiaenLiu @mattbit @pierlj