Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lockfile & clear runner disk #1868

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Update lockfile & clear runner disk #1868

merged 6 commits into from
Mar 28, 2024

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Mar 28, 2024

Description

Related Issue

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@Hartorn Hartorn requested a review from andreybavt March 28, 2024 10:11
@Hartorn Hartorn self-assigned this Mar 28, 2024
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 28, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Mar 28, 2024
@Hartorn Hartorn marked this pull request as ready for review March 28, 2024 12:26
@Hartorn Hartorn requested a review from a team as a code owner March 28, 2024 12:26
Inokinoki
Inokinoki approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/build-python.yml Outdated
- name: Check disk space
run: |
df -h
# - name: List installed packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup or we need to keep these steps?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hartorn I think we can remove the commented out stuff

@Hartorn Hartorn changed the title Update lockfile 2 Update lockfile & clear runner disk Mar 28, 2024
@Hartorn Hartorn enabled auto-merge (squash) March 28, 2024 14:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Hartorn Hartorn merged commit 3f777a4 into main Mar 28, 2024
16 checks passed
@Hartorn Hartorn deleted the update-lockfile-2 branch March 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inokinoki Inokinoki Inokinoki approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@Hartorn Hartorn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hartorn @andreybavt @Inokinoki