-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-2696] Recover daemonized ML worker with multi ML worker support #1884
Merged
Inokinoki
merged 13 commits into
main
from
fix/gsk-2696-check-if-daemon-mode-is-needed-was-broken
Apr 25, 2024
Merged
[GSK-2696] Recover daemonized ML worker with multi ML worker support #1884
Inokinoki
merged 13 commits into
main
from
fix/gsk-2696-check-if-daemon-mode-is-needed-was-broken
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: giskard/commands/cli_worker.py
Did you find this useful? React with a 👍 or 👎 |
Tested with two workers with pid 20252 and 20295:
|
…6-check-if-daemon-mode-is-needed-was-broken
…6-check-if-daemon-mode-is-needed-was-broken
Quality Gate failedFailed conditions |
kevinmessiaen
approved these changes
Apr 25, 2024
Inokinoki
deleted the
fix/gsk-2696-check-if-daemon-mode-is-needed-was-broken
branch
April 25, 2024 05:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We still have
-d
flags in the doc. However, the daemon mode is removed.This PR recovers daemon mode after having multi ML worker support.
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.pdm.lock
runningpdm update-lock
(only applicable whenpyproject.toml
has beenmodified)