Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dependencies installation on macos #1921

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented Apr 30, 2024

Description

Fixed dependencies installation on macos build by using fixing macos-12.

To fix the installation on macos-14 (arm64), we would require to have two different groups: pdm-project/pdm#2189 (comment)

Related Issue

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch for the macOS version and arch

@kevinmessiaen
Copy link
Member Author

LGTM, good catch for the macOS version and arch

Yes it was hard to find but it seems that we'll have to create separate group for windows/macos arm64 or wait that a version tensorflow-io-gcs-filesystem is released supporting both plateform/arch

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kevinmessiaen kevinmessiaen merged commit 9714654 into main Apr 30, 2024
16 checks passed
@kevinmessiaen kevinmessiaen deleted the fix/dependencies-install branch April 30, 2024 12:07
@Inokinoki
Copy link
Member

Inokinoki commented Apr 30, 2024

LGTM, good catch for the macOS version and arch

Yes it was hard to find but it seems that we'll have to create separate group for windows/macos arm64 or wait that a version tensorflow-io-gcs-filesystem is released supporting both plateform/arch

Thanks for the fix!
Yes, that was also my conclusion ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants