Disabled perturbation on date #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giskard/push/perturbation.py
Outdated
| @@ -121,7 +121,7 @@ def _apply_perturbation( | |||
| ds_slice_copy = ds_slice.copy() | |||
|
|
|||
| # Apply the transformation | |||
| if col_type == SupportedPerturbationType.NUMERIC: | |||
| if col_type == SupportedPerturbationType.NUMERIC and ds.df.dtypes[feature] in ["int64", "float64"]: | |||
There was a problem hiding this comment.
what about int32, float32, etc.?
I think this https://pandas.pydata.org/docs/reference/api/pandas.api.types.is_datetime64_any_dtype.html would be better
There was a problem hiding this comment.
I ended up using https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.api.types.is_any_real_numeric_dtype.html which is more robust.
As it will exclude all non-real numeric data type so we don't end up with the same issue with another pseudo-numeric data type.
…e' into bug/disabled_perturbation_on_date
rabah-khalek
approved these changes
May 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabled perturbation on date
Related Issue
Type of Change