Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistical Parity Difference test #1940

Merged
merged 4 commits into from
May 28, 2024
Merged

Statistical Parity Difference test #1940

merged 4 commits into from
May 28, 2024

Conversation

Sakayatsp
Copy link
Contributor

@Sakayatsp Sakayatsp commented May 27, 2024

Description

Related Issue

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

Copy link
Member

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes to take care of.

could you please remove the notebook?

The other ones display the scan of different models, we don't display the execution of one test. This notebook will be useful for the compliance. I guess you already have it in compliance-experiments?

giskard/testing/tests/statistic.py Outdated Show resolved Hide resolved
giskard/testing/tests/statistic.py Outdated Show resolved Hide resolved
giskard/testing/tests/statistic.py Outdated Show resolved Hide resolved
giskard/testing/tests/statistic.py Outdated Show resolved Hide resolved
giskard/testing/tests/statistic.py Outdated Show resolved Hide resolved
giskard/testing/tests/statistic.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 27, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@rabah-khalek rabah-khalek enabled auto-merge (squash) May 27, 2024 09:26
Copy link

sonarcloud bot commented May 27, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@rabah-khalek rabah-khalek merged commit 61f7d6a into main May 28, 2024
15 of 16 checks passed
@rabah-khalek rabah-khalek deleted the new_test_spd branch May 28, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants