Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSK-3589] Decouple giskard lib release from legacy-hub #1950

Merged
merged 8 commits into from
Jun 4, 2024
Merged

[GSK-3589] Decouple giskard lib release from legacy-hub #1950

merged 8 commits into from
Jun 4, 2024

Conversation

henchaves
Copy link
Member

@henchaves henchaves commented Jun 4, 2024 •
edited
Loading

Description

This PR updates the release process of giskard lib to make it independent of other Giskard repositories.

Related Issue

GSK-3589 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear Linear
Copy link

linear bot commented Jun 4, 2024

GSK-3589 Decouple giskard lib release from legacy-hub

@henchaves henchaves requested a review from Hartorn June 4, 2024 10:05
@henchaves henchaves marked this pull request as ready for review June 4, 2024 10:05
@henchaves henchaves requested a review from a team as a code owner June 4, 2024 10:05
@henchaves henchaves removed the request for review from a team June 4, 2024 10:05
@henchaves henchaves self-assigned this Jun 4, 2024
Hartorn
Hartorn requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step Create new project and install server wheel (Poetry) in build python should also be removed

Some other minor stuff to adjust

.github/workflows/build-python.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
@henchaves henchaves requested a review from Hartorn June 4, 2024 10:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Hartorn
Hartorn approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Anyway, only to test is to do a release :p

@henchaves henchaves merged commit d0ad7ac into main Jun 4, 2024
15 of 16 checks passed
@henchaves henchaves deleted the feature/gsk-3589-decouple-giskard-lib-release-from-legacy-hub branch June 4, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hartorn Hartorn Hartorn approved these changes

Assignees

@henchaves henchaves

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henchaves @Hartorn