New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does not respect git pull's quiet mode #30
Labels
Milestone
Comments
gitster
pushed a commit
to git/git
that referenced
this issue
Nov 1, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki/Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
fengguang
pushed a commit
to 0day-ci/git
that referenced
this issue
Nov 1, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki/Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org>
i found out this is an "option" sent by git to the "helpers" such as us. this is documented in the OPTIONS section of the documentation, as the "verbosity" option. something like this: diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index e7f857c1a..de7d6a27f 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -595,6 +595,7 @@ sub mw_capabilities {
print {*STDOUT} "import\n";
print {*STDOUT} "list\n";
print {*STDOUT} "push\n";
+ print {*STDOUT} "option\n";
if ($dumb_push) {
print {*STDOUT} "no-private-update\n";
}
@@ -612,8 +613,15 @@ sub mw_list {
}
sub mw_option {
- print {*STDERR} "remote-helper command 'option $_[0]' not yet implemented\n";
- print {*STDOUT} "unsupported\n";
+ my $option = shift;
+ my $value = shift;
+ if ($option eq "verbosity") {
+ $verbosity = $value;
+ print {*STDOUT} "ok\n"
+ } else {
+ print {*STDERR} "remote-helper command 'option $option' not yet implemented\n";
+ print {*STDOUT} "unsupported\n";
+ }
return;
}
then we need to figure out how to do multi-level log output in perl. i asked the git mailing list to see if they had a clue, because i've been told to fix this two times there already... :p |
gitster
pushed a commit
to git/git
that referenced
this issue
Nov 3, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki/Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitster
pushed a commit
to git/git
that referenced
this issue
Nov 7, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki/Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
anarcat
added a commit
to anarcat/git
that referenced
this issue
Nov 7, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki/Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org>
gitster
pushed a commit
to git/git
that referenced
this issue
Nov 8, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki/Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
anarcat
added a commit
to anarcat/Git-Mediawiki
that referenced
this issue
Nov 18, 2017
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately: Git-Mediawiki#30 Signed-off-by: Antoine Beaupré <anarcat@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Excerpt from
git-pull(1)
:Therefore, this remote should respect
-q
.The text was updated successfully, but these errors were encountered: