Xblanchot/sca 942/fix commit range in ci #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xblanchot-gg
force-pushed
the
xblanchot/SCA-942/fix_commit_range_in_ci
branch
from
e6f93d9
to
e00b33d
Compare
xblanchot-gg
force-pushed
the
xblanchot/SCA-942/fix_commit_range_in_ci
branch
3 times, most recently
from
db6164c
to
1a4b9d6
Compare
amascia-gg
reviewed
Aug 10, 2023
xblanchot-gg
force-pushed
the
xblanchot/SCA-942/fix_commit_range_in_ci
branch
from
1a4b9d6
to
d5a5115
Compare
GG-HH
requested changes
Aug 10, 2023
agateau-gg
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Looks good overall, just minor remarks.
The single-commit message is deceiving: I expect a commit whose message is "Add an util to do foo", to mainly add a function and use it, not split a module in 4 and introduce many functions.
Doing the split in a separate commit would have helped tracking the real changes.
xblanchot-gg
force-pushed
the
xblanchot/SCA-942/fix_commit_range_in_ci
branch
from
d5a5115
to
14476f4
Compare
GG-HH
approved these changes
Aug 10, 2023
agateau-gg
requested changes
Aug 11, 2023
xblanchot-gg
force-pushed
the
xblanchot/SCA-942/fix_commit_range_in_ci
branch
from
14476f4
to
dffd627
Compare
agateau-gg
approved these changes
Aug 11, 2023
amascia-gg
approved these changes
Aug 11, 2023
xblanchot-gg
force-pushed
the
xblanchot/SCA-942/fix_commit_range_in_ci
branch
from
dffd627
to
ef98d62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a util to get the previous state of the targeted branch in CI for github, and use it in sca scan ci.
It also removes the need of defining a custom env variable for PR in github CI. A custom env variable is still required for push event on github.
For now, SCA and IaC CI scans work only with github and gitlab CIs.
All other CIs will come in a next PR.