Send the scanned repository's origin url as an extra header #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sylvain-baud-gg IMO sending the entire URL is better, as GIM can then extract the required information from it (repo name, type of repo...) |
There was a problem hiding this comment.
I only see a change on the scan diff . I think the iac_scan_all should also fetch the remote url and send it.
Some edge case to keep in mind :
- Local repo only --> We want to send None
- Case of repo containing sub repos. --> We want to send the repo linked to the path provided.
- Launching the command inside a repoA to scan a repoB --> We want to send repoB
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
from
29ee9e3
to
71f8c8a
Compare
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
from
71f8c8a
to
d133243
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #747 +/- ##
==========================================
+ Coverage 91.68% 91.86% +0.18%
==========================================
Files 154 154
Lines 6348 6380 +32
==========================================
+ Hits 5820 5861 +41
+ Misses 528 519 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
4 times, most recently
from
a51d836
to
006853a
Compare
|
I suggest you review commits one by one |
Paul-GitGuardian
requested review from
sylvain-baud-gg
and removed request for
sylvain-baud-gg
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
3 times, most recently
from
c681d44
to
8ae0002
Compare
sylvain-baud-gg
approved these changes
Oct 24, 2023
|
@agateau-gg thank you for your review on my other PR, this one became our priority for the next days. Can you check it please? As said above, it is easier commit by commit imo |
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
2 times, most recently
from
b911e99
to
a536937
Compare
agateau-gg
requested changes
Oct 25, 2023
GG-HH
reviewed
Oct 25, 2023
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
2 times, most recently
from
1d23ca0
to
cc0e04c
Compare
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
4 times, most recently
from
5c07b61
to
e96bb79
Compare
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
3 times, most recently
from
2dc67a6
to
785275b
Compare
GG-HH
approved these changes
Oct 26, 2023
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
2 times, most recently
from
144a86f
to
c99790a
Compare
…ory url as header
Paul-GitGuardian
force-pushed
the
pbes/IAC-350/send-repo-url-in-scan-request
branch
from
c99790a
to
f2ad1be
Compare
agateau-gg
approved these changes
Oct 30, 2023
Paul-GitGuardian
deleted the
pbes/IAC-350/send-repo-url-in-scan-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute the repository remote url. Pick one at random if several are found. This will allow a better connection between ggshield and GIM's database.
This will appear in the request headers:
'GGShield-Repository-URL': 'https://github.com/bridgecrewio/terragoat.git'All verticals will send this header. For IAC/SCA, the repository found is based on the provided path in the command.
For Secrets:
archive,docker,docker-archive,docset,pypi.ci,pre-commit,pre-push,pre-receive,range. This is the directory that is checked bycheck_git_dir.pathsubcommand, if thepathsargument has exactly one element, it is sent. Otherwise cwd is sent.reposubcommand, therepositoryargument or the local clone path is sent, depending on the type of the provided argument.