Replace 0 bytes in document instead of raising an exception #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 4 4
Lines 304 305 +1
=======================================
+ Hits 303 304 +1
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
agateau-gg
force-pushed
the
agateau/handle-0-bytes
branch
from
d4d8097
to
797b191
Compare
This factorize handling of 0 bytes instead of leaving it up to all callers.
agateau-gg
force-pushed
the
agateau/handle-0-bytes
branch
from
797b191
to
ec02027
Compare
pierrelalanne
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our API expects documents to be text documents: it rejects documents containing
0bytes. Sometimes text documents do contain such bytes though, see GitGuardian/ggshield#155 for an example.Instead of forcing all API users to handle
0bytes, replace them with the Unicode replacement character (�)