API Keys read from environment variables

Classes/Image Upload/ImgurClient.swift

@@ -26,7 +26,7 @@ final class ImgurClient {
     }
 
     private static let hostpath = "https://api.imgur.com/3/"
-    private static let headers: HTTPHeaders = ["Authorization": "Client-ID \(Secrets.imgurClientID())"]
+    private static let headers: HTTPHeaders = ["Authorization": "Client-ID \(Secrets.Imgur.clientId)"]
 
     func request(_ path: String,
                  method: HTTPMethod = .get,

Classes/Login/GithubClient+AccessToken.swift

@@ -21,8 +21,8 @@ extension GithubClient {
         ) {
         let parameters = [
             "code": code,
-            "client_id": Secrets.githubClientID(),
-            "client_secret": Secrets.githubClientSecret()
+            "client_id": Secrets.GitHub.clientId,
+            "client_secret": Secrets.GitHub.clientSecret
         ]
         let headers = [
             "Accept": "application/json"

Classes/Login/LoginSplashViewController.swift

@@ -9,7 +9,7 @@
 import UIKit
 import SafariServices
 
-private let loginURL = URL(string: "http://github.com/login/oauth/authorize?client_id=\(Secrets.githubClientID())&scope=user+repo+notifications")!
+private let loginURL = URL(string: "http://github.com/login/oauth/authorize?client_id=\(Secrets.GitHub.clientId)&scope=user+repo+notifications")!
 private let callbackURLScheme = "freetime://"
 
 final class LoginSplashViewController: UIViewController, GithubSessionListener {

Classes/Settings/SettingsViewController.swift

@@ -90,7 +90,7 @@ NewIssueTableViewControllerDelegate {
     // MARK: Private API
 
     func onReviewAccess() {
-        guard let url = URL(string: "https://github.com/settings/connections/applications/\(Secrets.githubClientID())")
+        guard let url = URL(string: "https://github.com/settings/connections/applications/\(Secrets.GitHub.clientId)")
             else { fatalError("Should always create GitHub issue URL") }
         // iOS 11 login uses SFAuthenticationSession which shares credentials with Safari.app
         if #available(iOS 11.0, *) {

Classes/Systems/Secrets.swift

@@ -0,0 +1,35 @@
+//
+//  Secrets.swift
+//  Freetime
+//
+//  Created by Sherlock, James on 23/11/2017.
+//  Copyright © 2017 Ryan Nystrom. All rights reserved.
+//
+
+import Foundation
+
+enum Secrets {
+
+    enum GitHub {
+        static let clientId = Secrets.environmentVariable(named: "GITHUB_CLIENT_ID")
+        static let clientSecret = Secrets.environmentVariable(named: "GITHUB_CLIENT_SECRET")
+    }
+
+    enum Imgur {
+        static let clientId = Secrets.environmentVariable(named: "IMGUR_CLIENT_ID")
+    }
+
+    fileprivate static func environmentVariable(named: String) -> String {
+
+        let processInfo = ProcessInfo.processInfo
+
+        guard let value = processInfo.environment[named] else {
+            print("‼️ Missing Environment Variable: '\(named)'")
+            return ""
+        }
+
+        return value
+
+    }
+
+}

Podfile.lock

@@ -110,4 +110,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 42663ce5abae69b05b234e40c92d7f02b29efe06
 
-COCOAPODS: 1.3.1
+COCOAPODS: 1.2.1