New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of more options button and notification cell #119

Merged
merged 13 commits into from Jul 19, 2017

Conversation

Projects
None yet
2 participants
@BasThomas
Collaborator

BasThomas commented Jul 12, 2017

Ref #118

This PR:

  • Makes the More Options button in the issue overview say "More Options" instead of "bullets-hollow"
  • Makes the notification cell accessible as a whole, as well as mentioning its type (issue, pr or commit)

BasThomas added some commits Jul 11, 2017

Make SelectableCells accessible and set their label to the subviews l…
…abels

This makes the cell an accessibility element (eg. Review GitHub Access under Settings) and mention that A: the cell is a button and B: its label is "Review GitHub Access"

Before this change, the label was an element and did not mention it was also a button

@BasThomas BasThomas referenced this pull request Jul 12, 2017

Open

Improve accessibility #118

16 of 29 tasks complete
@@ -98,6 +100,10 @@ final class NotificationCell: SwipeSelectableCell {
textLabel.attributedText = viewModel.title.attributedText
dateLabel.setText(date: viewModel.date)
reasonImageView.image = viewModel.type.icon?.withRenderingMode(.alwaysTemplate)
accessibilityLabel = contentView.subviews
.flatMap { $0.accessibilityLabel }
.reduce("", { $0 + ".\n" + $1 })

This comment has been minimized.

@BasThomas

BasThomas Jul 12, 2017

Collaborator

the ./n-s makes VoiceOver read these as sentences instead of just one, long sentence, making the different labels / elements separated.

@BasThomas

BasThomas Jul 12, 2017

Collaborator

the ./n-s makes VoiceOver read these as sentences instead of just one, long sentence, making the different labels / elements separated.

This comment has been minimized.

@rnystrom

rnystrom Jul 12, 2017

Member

Same note about moving this to override?

@rnystrom

rnystrom Jul 12, 2017

Member

Same note about moving this to override?

This comment has been minimized.

@rnystrom

rnystrom Jul 14, 2017

Member

What about this one?

@rnystrom

rnystrom Jul 14, 2017

Member

What about this one?

This comment has been minimized.

@BasThomas

BasThomas Jul 15, 2017

Collaborator

See the comment on the other one:

That would be a little restricting though - we can't access the viewModel in the NotificationCell, which I used to provide the type (Issue / PR / commit).

@BasThomas

BasThomas Jul 15, 2017

Collaborator

See the comment on the other one:

That would be a little restricting though - we can't access the viewModel in the NotificationCell, which I used to provide the type (Issue / PR / commit).

Show outdated Hide outdated Classes/Views/SelectableCell.swift
@@ -98,6 +100,10 @@ final class NotificationCell: SwipeSelectableCell {
textLabel.attributedText = viewModel.title.attributedText
dateLabel.setText(date: viewModel.date)
reasonImageView.image = viewModel.type.icon?.withRenderingMode(.alwaysTemplate)
accessibilityLabel = contentView.subviews
.flatMap { $0.accessibilityLabel }
.reduce("", { $0 + ".\n" + $1 })

This comment has been minimized.

@rnystrom

rnystrom Jul 12, 2017

Member

Same note about moving this to override?

@rnystrom

rnystrom Jul 12, 2017

Member

Same note about moving this to override?

@rnystrom

This comment has been minimized.

Show comment
Hide comment
@rnystrom

rnystrom Jul 12, 2017

Member

SO GOOD, I love it

Member

rnystrom commented Jul 12, 2017

SO GOOD, I love it

@rnystrom rnystrom merged commit 6859fdb into master Jul 19, 2017

rnystrom added a commit that referenced this pull request Jul 19, 2017

@BasThomas BasThomas deleted the improve-accessibility branch Jul 24, 2017

@BasThomas BasThomas changed the title from Improve accessibility to Improve accessibility of more options button and notification cell Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment