This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Start refactoring text views with StyledText #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnystrom
added a commit
that referenced
this pull request
Apr 22, 2018
* bump version to 1.19.0 (#1587) * [ADD] Refactoring short cut handler to use enum based Routes (#1591) * [CHOR] Delete old bookmark model and cleanup folder structure (#1589) * update notification cells when ago string changes (#1588) * Removing #available conditionals (#1578) * Release notifications (#1546) * releases WIP * loading releases working * Sign in: Fix UI in smaller screens (#1595) * Remove HangingChadItem (#1605) Referencing #1327 (comment) * [WIP] Refactor networking to shared lib (#1602) * [WIP] Refactor networking to shared lib * notification models as codable and tests * default request params * break out into files * fix tests * check notification values * add milestones * add milestone response * repo notifications * refactor v3 response * refactor to support passing response to response initializer * add release fetch and model * add examples from githawk * notifications working * almost all notifications requests migrated * finish notification migration, add graphql request/response * replace issue requests * replace milestones request * fetch assignees migrated * readme fetch migrated * migrate badge request * delete unused request from client * remove paging * nearly done w/ migration * local build green * refactor gql fetches, replace mutations * build green, slim down client * strip session manager from client * everything working * Add merge status tests (#1604) * Add merge status tests * Introduce containsAll and containsNone * Rename containsAll to containsOnly * Accessibility improvements (#1603) * Add an a11y hint to the navigationbar title * Improve accessibility for merge contexts * Improve accessibility for merge summaries * Improve accessibility for the merge button * update message VC pod (#1610) * remove dead code (#1611) * Make the repositories' desciption optional (#1617) * Fancy new README (#1462) * add new readme animation * loop * update readme * clean up login client (#1612) * [ADD] Center align App Store badge (#1620) * Immutability with mutability blog post (#1622) * add immutable blog post * add closing * fix indenting (#1623) * raw template * better words (#1624) * Copyedit (#1625) * swap dates (#1626) * Add ContextMenu library (#1632) * add contextmenu lib * update to latest * Update IGListKit lib to latest and swift preview branch (#1633) * update IGListKit lib to latest and swift preview branch * add swift subspec * Add PDF support (#1596) * Add string extension for searching pdf files (#1552) * Create RepositoryWebViewController (#1552) * Initial presenting of the pdf files (#1552) * refactor: Rename String+Resource -> String+BinaryFile (#1552) * Build destination URL (#1552) * Configure title (#1552) * Encode file path * Use EmptyView for errors * Replace UIWebView with WKWebView * Review fixes * refactor: Make binarySuffix computed property * Unify if-else path * Group guard statements * Move session management to local pod and add app group (#1636) * move session management to local pod and add app group * copy paste fail from SO * fix save using old keys (#1637) * token response needs to accept json (#1638) * show files without patches (#1639) * Create a custom UIAccessibilityElement for the merge button (#1643) * Refactor PeopleViewController to subclass BaseListViewController (#1512) * Remove People.storyboard * Refactor PeopleCell * Refactor PeopleViewController to BaseListViewController * Add PeopleSectionController * Add paging params to assignees request * Resolve networking refactor conflicts * Init PeopleViewController manually * Remove unused method * test out context menu on labels, people, milestones (#1644) * request V3PullrequestRequest added * UI model, cell and section controller added * request requesting pull request information in IssuesViewController * displaying data Displaying branches in IssuesViewController * ui moved branches label higher * rename files renamed * Remove duplicate iPad7,3 case * text setup text setup moved to IssueTargetBranchModel * cleanup commented code removed * update ContextMenu pod (#1654) * Move references to old url (#1652) * Update 3D touch items when switching account. (#1646) * bugfix(Issue-1592-3D-Touch-Not-Updated): update 3D touch items when switching account. * bugfix(Issue-1592-3D-Touch-Not-Updated): switch to the most recent account and update 3D touch user item when switching account. * fix an indentation problem to ShortcutHandler * add the app delegate as a listener and configure ShortcutHandler on didFocus(...) * restore whitespace * consistent alignment * remove done button from context menu VCs (#1655) * Update Apollo to 0.8.0 and codegen to 0.18.8 (#1656) * update styledtext pod (#1657) * GraphQL - added base branch reference to GraphQL query - removed previous base branch request implementation - IssuesViewController adopted new request implementation * requests fetchBranches method removed * old request removed V3PullRequestRequest * Start refactoring text views with StyledText (#1658) * refactoring with styledtext * issue rename refactored * fix tests * Refactor labeled events to use StyledText (#1659) * refactor tap handling on attributed views * styled cell interaction working * share menu code * label events finished * Infer types and arguments in-app * Infer types and arguments in local pods * Rename "Archived" to "All" (#1662) * Fixing overlap content after react menu on comment. (#1577) * Fixing overlap content after react menu. * more elegant solution for the fix. :)) * Make Toast init non-optional, post a11y notification (#1670) * add feed.viewDidAppear(animated) in viewDidAppear. * Refactor markdown parsing to use text lib (#1674) * milestones refactored with styled text * reference refactored * refactor commit references * fix styled text bug * request event refactored * refactor titles * warm caches for bg-gen models * delete old text cell * move shortlinks into MMMarkdown * almost there * build green * running and trimming whitespaces * styled text working * fix tests * tests passing * Readd repo notifications (#1689) * Differentiate between a repo and all request * Bonus track: a11y * Use Bool.description * Enable invitation decoding (#1687) * Fix invitation decoding * Add a test * Remove unused WriteButton class and related assets. (#1676) * add feed.viewDidAppear(animated) in viewDidAppear. (#1678) * Port to Xcode 9.3 (#1696) * Rewrite markdown parsing with cmark (#1704) * add cmark lib, build succeeds * building and running (with dupe asserts) * list newlines, quote styles * tables working in cmark * fix table bg color math and code bg color * code block highlighting only when theres a language * share code block logic * mentions need @ * update cmark lib * shortlinks * detect issue shortlinks * simplify and correct shortlinks * remove html comments * tests passing * Enable view source to open in GitHawk * Simplify deselectRow logic * New text system adopted - changed NSAttributedStringSizing to StyledTextRenderer (IssueTargetBranchModel) - Removed redundand code from IssuesViewController - Changed method for text height in IssueBranchesSectionController * update cmark lib (#1708) * retain badge object when fetching notifications (#1709) * add Reply action on didTapMore(cell: sender:) * make messageView firstResponder onReply action * focus on the comment on reply action * quote a substring of the comment and mention the user in messageView on reply. * remove "import MessageViewController" from IssueCommentSectionController * refactor the code * Change two flatMaps to compactMap * Improve number readability * make IssueCommentSectionController conform to MarkdownStyledTextViewDelegate (#1718) * support the case for IssueTargetBranchModel (#1720) * Link to the right repo (#1716) * update cmark with checkbox support (#1725) * Restore to automatic code signing (#1726) * restore to automatic signing * set all profiles to dev for auto signing * Remove MMMarkdown dependency (#1729) * replace old markdown callsites * unit tests working * remove unused parsing * final removal of old parsing, build and tests succeed * remove dependency * capture readme ref branch * Fix flickering when navigating back (#1728) * Always update inbox when receiving changes (#1730) * Skip loading status when inbox empty (#1731) * Show empty string when no markdown (#1732) * Add title to merge toggle * use word "change" * less thrashy loading spinner * correct removal of bg view * github syntax search working * MessageViewController update (#1741) * update action label when value changes, make actions diffable * Update IGListKit swift branch after rebase * Update MessageViewController pod * fix build, update w/ latest fixes * use utf16 for tag ranges (#1738) * update action label when value changes, make actions diffable (#1739) * merge model should return true for use with binding SC (#1742) * smaller labels (#1744) * add extra space for label events (#1751) * Code blocks share system font adjustment, use StyledText (#1752) * add space to default search string (#1750) * update StyledText to fix NSAttributedString overwriting (#1753)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes master