This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Show release notes UI in inbox when notable new features #2473
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // | ||
| // NewFeaturesCell.swift | ||
| // Freetime | ||
| // | ||
| // Created by Ryan Nystrom on 11/22/18. | ||
| // Copyright © 2018 Ryan Nystrom. All rights reserved. | ||
| // | ||
|
|
||
| import UIKit | ||
| import SnapKit | ||
|
|
||
| protocol NewFeaturesCellDelegate: class { | ||
| func didTapClose(for cell: NewFeaturesCell) | ||
| } | ||
|
|
||
| final class NewFeaturesCell: UICollectionViewCell { | ||
|
|
||
| static let inset = UIEdgeInsets( | ||
| top: Styles.Sizes.rowSpacing, | ||
| left: Styles.Sizes.gutter, | ||
| bottom: Styles.Sizes.rowSpacing, | ||
| right: Styles.Sizes.gutter | ||
| ) | ||
|
|
||
| weak var delegate: NewFeaturesCellDelegate? | ||
|
|
||
| private let label = UILabel() | ||
|
There was a problem hiding this comment. This could be a bit more descriptive, I think? 😄 |
||
| private let closeButton = UIButton() | ||
|
|
||
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
|
|
||
| isAccessibilityElement = true | ||
|
|
||
| backgroundColor = .white | ||
| contentView.backgroundColor = Styles.Colors.Blue.light.color | ||
| contentView.layer.cornerRadius = Styles.Sizes.cardCornerRadius | ||
| contentView.layer.borderWidth = 1 / UIScreen.main.scale | ||
|
There was a problem hiding this comment. Should this be There was a problem hiding this comment. Looks to be a 1px thin line rather than a 1pt thin line! I've used this a couple times 😄 There was a problem hiding this comment. Ah, a |
||
| contentView.layer.borderColor = Styles.Colors.blueGray.color.cgColor | ||
|
|
||
| contentView.addSubview(label) | ||
| contentView.addSubview(closeButton) | ||
|
|
||
| let tint = Styles.Colors.Blue.medium.color | ||
| label.textColor = tint | ||
| label.font = Styles.Text.secondaryBold.preferredFont | ||
| label.isAccessibilityElement = false | ||
|
|
||
| let closeButtonSize = Styles.Sizes.icon.width | ||
| closeButton.setImage(UIImage(named: "x-small")?.withRenderingMode(.alwaysTemplate), for: .normal) | ||
| closeButton.tintColor = tint | ||
| closeButton.layer.cornerRadius = closeButtonSize / 2 | ||
| closeButton.addTarget(self, action: #selector(onCloseButton), for: .touchUpInside) | ||
| closeButton.accessibilityLabel = NSLocalizedString("Dismiss new feature modal", comment: "") | ||
|
|
||
| label.snp.makeConstraints { make in | ||
| make.centerY.equalToSuperview() | ||
| make.left.equalTo(Styles.Sizes.gutter) | ||
| make.right.lessThanOrEqualTo(closeButton.snp.left).offset(-Styles.Sizes.columnSpacing) | ||
| } | ||
| closeButton.snp.makeConstraints { make in | ||
| make.centerY.equalToSuperview() | ||
| make.right.equalTo(-Styles.Sizes.gutter) | ||
| make.size.equalTo(closeButtonSize) | ||
| } | ||
| } | ||
|
|
||
| required init?(coder aDecoder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
|
|
||
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| contentView.frame = UIEdgeInsetsInsetRect(CGRect( | ||
|
There was a problem hiding this comment. Is this the same as There was a problem hiding this comment. That’s for x and y insetting (not There was a problem hiding this comment. Swift 4.2 (codebase still 4.0)
|
||
| x: safeAreaInsets.left, | ||
| y: bounds.minY, | ||
| width: bounds.width - safeAreaInsets.left - safeAreaInsets.right, | ||
| height: bounds.height | ||
| ), NewFeaturesCell.inset) | ||
| } | ||
|
|
||
| @objc private func onCloseButton() { | ||
|
There was a problem hiding this comment. Can we also add an There was a problem hiding this comment. I’m actually not sure what that is, but this probably needs better AX There was a problem hiding this comment. It lets you use a z-swipe to dismiss the view controller. |
||
| delegate?.didTapClose(for: self) | ||
| } | ||
|
|
||
| func configure(with version: String) { | ||
| label.text = String.localizedStringWithFormat( | ||
| NSLocalizedString("New features in %@!", comment: ""), | ||
| version | ||
| ) | ||
| } | ||
|
|
||
| override func accessibilityPerformEscape() -> Bool { | ||
|
|
||
| delegate?.didTapClose(for: self) | ||
| return true | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| // | ||
| // NewFeaturesController.swift | ||
| // Freetime | ||
| // | ||
| // Created by Ryan Nystrom on 11/22/18. | ||
| // Copyright © 2018 Ryan Nystrom. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import GitHubAPI | ||
| import IGListKit | ||
|
|
||
| final class NewFeaturesController { | ||
|
|
||
| // change to true for hardcoded testing | ||
| private let testing = false | ||
|
|
||
| var version: String { | ||
| if testing { | ||
| return "test" | ||
| } | ||
| return Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? "" | ||
|
There was a problem hiding this comment. Pretty sure this is safe; maybe use implicitly unwrapped optionals or an There was a problem hiding this comment. Want to avoid any implicit unwraps for stuff that can’t be tested. If this changed out from under us it’d stink (however unlikely). There was a problem hiding this comment. An |
||
| } | ||
|
|
||
| private var fetchURL: URL? { | ||
| return URLBuilder(host: "raw.githubusercontent.com") | ||
| .add(paths: ["GitHawkApp", "Release-Notes", "master", "versions", "\(version).md"]) | ||
| .url | ||
| } | ||
|
|
||
| private let session: URLSession = { | ||
| let config = URLSessionConfiguration.default | ||
| config.requestCachePolicy = .reloadIgnoringLocalCacheData | ||
| config.urlCache = nil | ||
| return URLSession.init(configuration: config) | ||
| }() | ||
|
|
||
| private let userDefaultsKey = "com.freetime.new-features-controller.has-fetched" | ||
|
|
||
| private var hasFetchedLatest: Bool { | ||
| get { | ||
| guard let last = UserDefaults.standard.string(forKey: userDefaultsKey) else { | ||
| return false | ||
| } | ||
| // value kept to latest version when seen | ||
| // pinned to old versions (or empty) when out of date | ||
| return last >= version | ||
| } | ||
| set { | ||
| if newValue { | ||
| UserDefaults.standard.set(version, forKey: userDefaultsKey) | ||
| } else { | ||
| UserDefaults.standard.removeObject(forKey: userDefaultsKey) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func fetch(success: @escaping (String) -> Void) { | ||
| guard let url = fetchURL, | ||
| (testing == true || hasFetchedLatest == false) | ||
| else { return } | ||
| hasFetchedLatest = true | ||
|
|
||
| let task = session.dataTask(with: url) { (data, response, _) in | ||
| if let response = response as? HTTPURLResponse, | ||
| response.statusCode == 200, | ||
| let data = data, | ||
| let string = String(data: data, encoding: .utf8) { | ||
| DispatchQueue.main.async { | ||
| success(string) | ||
| } | ||
| } | ||
| } | ||
| task.resume() | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| // | ||
| // NewFeaturesSectionController.swift | ||
| // Freetime | ||
| // | ||
| // Created by Ryan Nystrom on 11/22/18. | ||
| // Copyright © 2018 Ryan Nystrom. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import IGListKit | ||
| import ContextMenu | ||
|
|
||
| final class NewFeaturesSectionController: ListSwiftSectionController<String>, | ||
| NewFeaturesCellDelegate { | ||
|
|
||
| private var markdown: String? | ||
| private let controller = NewFeaturesController() | ||
| private var closed = false | ||
|
There was a problem hiding this comment. What kind of state does this represent? And super-nit: There was a problem hiding this comment. If the user tapped the X to dismiss |
||
|
|
||
| override init() { | ||
| super.init() | ||
| controller.fetch { [weak self] markdown in | ||
| self?.markdown = markdown | ||
| self?.update() | ||
| } | ||
| } | ||
|
|
||
| override func createBinders(from value: String) -> [ListBinder] { | ||
|
There was a problem hiding this comment. This is some... interesting code. Having difficulties parsing/understanding this completely :) There was a problem hiding this comment. Takes some getting used to. Heavy use of generics but result is completely type safe. |
||
| guard let markdown = self.markdown, | ||
| closed == false | ||
| else { return [] } | ||
| return [ | ||
| binder( | ||
| markdown, | ||
| cellType: ListCellType.class(NewFeaturesCell.self), | ||
| size: { | ||
| return $0.collection.cellSize( | ||
| with: Styles.Sizes.tableCellHeight | ||
| + NewFeaturesCell.inset.top | ||
| + NewFeaturesCell.inset.bottom | ||
| ) | ||
| }, | ||
| configure: { [weak self] (cell, _) in | ||
| guard let `self` = self else { return } | ||
| cell.configure(with: self.controller.version) | ||
| cell.delegate = self | ||
| }, | ||
| didSelect: { [weak self] _ in | ||
| self?.showChanges(markdown: markdown) | ||
| }) | ||
| ] | ||
| } | ||
|
|
||
| private func showChanges(markdown: String) { | ||
| viewController?.showContextualMenu(IssuePreviewViewController( | ||
| markdown: markdown, | ||
| owner: "GitHawkApp", | ||
|
There was a problem hiding this comment. I think someone added the GitHawk owner/repo combination in a constant somewhere? Not sure who/where. There was a problem hiding this comment. @BasThomas Yup I did! But its in the Templates pull request which hasn't been merged |
||
| repo: "GitHawk", | ||
| title: String.localizedStringWithFormat( | ||
| NSLocalizedString("New in %@", comment: ""), | ||
| controller.version | ||
| ), | ||
| asMenu: true | ||
| )) | ||
| } | ||
|
|
||
| // MARK: NewFeaturesCellDelegate | ||
|
|
||
| func didTapClose(for cell: NewFeaturesCell) { | ||
| closed = true | ||
| update() | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this does/when it is used? What is this
ViewControllershowing again?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previewing markdown