Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Repo overview header including watchers, stars & forks #2624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viktorasl
Copy link
Contributor

Closes #876 and #1184 + adds watchers count.
Picked quite simplified styling, hopefully it's good enough.
Not sure if implemented StyledTextBuilder correctly.

simulator screen shot - iphone xr - 2019-01-23 at 22 32 52

@j-f1
Copy link

j-f1 commented Jan 23, 2019

Can you add UI so we can star and watch repos?

@viktorasl
Copy link
Contributor Author

Yep, probably I could. The question is whether interactable elements should be the same in the header or should I move them to i.e 3-dots button (though it will make quite big action sheet) or any other option?

Sent with GitHawk

@ijm8710
Copy link

ijm8710 commented Jan 24, 2019

I honestly think what would make the most sense is to just create an isolated icon(s) similar to where you have the bookmark one top right. Honestly a star/watch should probably just replace the bookmark functionality as the combination of either of them basically are just a better implementation of a bookmarked repo anyway.

@viktorasl
Copy link
Contributor Author

Yes, but that will require to think more about:

  1. Bookmark icon should be changed to?
  2. Bookmarks tab should contain watched & starred repos probably. I guess it could have tabbed UI like repo overview.

I would be more than happy to implement that.

@ijm8710
Copy link

ijm8710 commented Jan 24, 2019

  1. Would probably make sense to have an enlarged eye and star icon similar to the icons you’ve already used for the pr
  2. Perhaps but they actually are already in the inbox menu dropdown if you go to “repos”. There’s an option for watched repos. Figure it might just make sense to add another for starred repos and just keep bookmarks issue/pr based.

Either way I agree it would require more to think about. I think your add here is great! Was just offering another approach to how I’d envision @j-f1 ‘s comment idea.

@Huddie Huddie added the 💤 awaiting review Pull Request is awaiting code reviews label Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💤 awaiting review Pull Request is awaiting code reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants