This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Added labels equatable check to ListDiffable isEqual method #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasThomas
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
Swift 4.1 please Swift 4.1 please Swift 4.1 please 😇 (this is why)
|
@BasThomas that 4.1 change is doooooope |
|
omfg, pls Sent with GitHawk |
|
And it's getting even better, potentially! apple/swift#12598 |
rnystrom
reviewed
Oct 25, 2017
| @@ -56,5 +56,6 @@ class RepositoryIssueSummaryModel: ListDiffable { | |||
| && author == object.author | |||
| && created == object.created | |||
| && title.attributedText.string == object.title.attributedText.string | |||
| && labels == object.labels | |||
There was a problem hiding this comment.
Note that this check is O(n) (comparing all contents of an array). I'm going to clean this up to be much faster.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715