-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to close milestone when running on AppVeyor but it works locally #439
Comments
Ok, I figured out a few things:
So, either I am on a wild goose chase and this warning has nothing to do with the problem causing my build to fail or, as I mentioned in my original comment, this warning somehow gets treated as an exception but only on AppVeyor. |
@AdmiringWorm are you aware of any issues in this area? Specifically with regard to how things work on AppVeyor compared to locally? @Jericho are you in a position to run a test without the |
I renamed the "Paging" milestone to "99.99.99 - Paging" to satisfy the naming convention and launched a new build before going to lunch. Just came back and I see that the build completed successfully. I think this proves that the warning is interpreted as a failure causing the build script to fail but only on AppVeyor. |
@gep13 I am not aware of anything. |
@AdmiringWorm is there a way to confirm what output is being used by GRM for warnings and errors? i.e. are we doing this wrong, and we should alter how these messages are being written out of the application? |
While @AdmiringWorm is researching, does it make sense to change GRM to avoid invoking the There are 7 calls to I'm volunteering to submit a PR if you think it makes sense. |
@gep13 we are specifically outputting warnings and higher to There are divided opinions on the correct approach, and some believe only errors should be shown on I am hesitant to change it, though, but we may want to detect if we are running on appveyor and then output warnings to stdout instead (or if we are running on a CI in general). |
…ading coverage result to Coveralls.io or CodeCov. This change allows the build script to continue even when uploading coverage results fails. This is the same problem I reported here: GitTools/GitReleaseManager#439
…ading coverage result to Coveralls.io or CodeCov. This change allows the build script to continue even when uploading coverage results fails. This is the same problem I reported here: GitTools/GitReleaseManager#439
This updates the handling of how we output log messages to the console to instead of blindly outputting warning messages to stderr all the time, it will instead check if an environment variable called `CI` is available and set to true, or the user themself have specified the `--ci` argument. When CI system is detected, any warnings will instead be outputted to the normal stdout along with normal informational messages.
(#439) Add option to disable warning to stderr
🎉 This issue has been resolved in version 0.17.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
The last step of my Cake script when I publish a new release of my library is to close the GitHub milestone. Unfortunately, it's failing when my Cake script is running on AppVeyor (see AppVeyor log here and also screenshot provided below).
I'm running GitReleaseManager in Verbose mode but there is very little info about what went wrong which makes it tough to investigate the problem.
I executed the exact same command from my laptop and it completed successfully:
I have checked and double-checked the GitHub token configured in my AppVeyor account and I am confident that it is correct therefore I have ruled out that this could be caused by an authentication issue.
One thing I have noticed is that I am getting a warning about
No valid version was found on Paging
. In fact this warning is highlighted in red on AppVeyor which leads me to suspect that it could be more serious that a mere warning. I can see this same warning when I run GRM on my laptop but it's not highlighted, and GRM is able to continue to completion seemingly without any problems.The text was updated successfully, but these errors were encountered: