-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An exception is thrown when issue has labels in include and exclude list #574
Comments
AdmiringWorm
added a commit
to AdmiringWorm/GitReleaseManager
that referenced
this issue
Feb 8, 2024
This updates the handling on how we are excluding labels when generating release notes. This allows issues to be assigned with a normal label, but still be excluded if a different label is listed in the exclusion list. Previously you would need to add and remove labels between drafting a release notes.
6 tasks
AdmiringWorm
added a commit
to AdmiringWorm/GitReleaseManager
that referenced
this issue
Feb 8, 2024
This updates the handling on how we are excluding labels when generating release notes. This allows issues to be assigned with a normal label, but still be excluded if a different label is listed in the exclusion list. Previously you would need to add and remove labels between drafting a release notes.
gep13
pushed a commit
to AdmiringWorm/GitReleaseManager
that referenced
this issue
Mar 9, 2024
This updates the handling on how we are excluding labels when generating release notes. This allows issues to be assigned with a normal label, but still be excluded if a different label is listed in the exclusion list. Previously you would need to add and remove labels between drafting a release notes.
gep13
added a commit
that referenced
this issue
Mar 9, 2024
🎉 This issue has been resolved in version 0.17.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Whet attempting to draft a new release, and one or more issues has multiple labels specified where one of the labels is in the include list, and a different label is in the exclude list GRM is throwing an exception making drafting of the release unable to proceed.
Expected Behavior
I would expect the exclude list to take precedence of anything specified in the include list, and issues with any label in the exclude list would be excluded from the drafted release notes.
Actual Behavior
An exception is thrown and aborts the release draft.
Possible Fix
Before throwing an exception, check if any of the labels specified in the exclude list is present. If it is then continue to the next issue without further processing.
Steps to Reproduce
Context
Quite often we have all issues labeled with one of the labels in the include list, and have a very specific label to exclude them from the release notes.
Since this is not working, we always have to remove one of the labels and re-apply them after drafting the release notes.
Your Environment
The text was updated successfully, but these errors were encountered: