Incorrect version number shown in artifacts #59
Comments
|
@GeertvanHorrik @JakeGinnivan when running the build on AppVeyor, I am using the This is where I am executing GitVersion on AppVeyor: https://github.com/GitTools/GitReleaseManager/blob/develop/BuildScripts/default.ps1#L418 |
|
If you are using the commonassemblyinfo trick then those attributes won't exist in each assemblyinfo file. You will need to specify the file name Sent from my Windows Phone From: Gary Ewan Parkmailto:notifications@github.com @GeertvanHorrikhttps://github.com/GeertvanHorrik @JakeGinnivanhttps://github.com/JakeGinnivan when running the build on AppVeyor, I am using the /UpdateAssemblyInfo true flag, so the compiled assembly should be using the generated semantic version number, but looks like this isn't happening. Any thoughts on what could be going on here? Cheers! This is where I am executing GitVersion on AppVeyor: https://github.com/GitTools/GitReleaseManager/blob/develop/BuildScripts/default.ps1#L418 — |
|
I am not using that technique, just straight up AssemblyInfo files in each project. |
- GitVersion was being executed from the BuildScripts folder, therefore there were no AssemblyInfo files to update - By passing in rootDirectory as the first parameter, it will be able to find and update the correct attributes
- GitVersion was being executed from the BuildScripts folder, therefore there were no AssemblyInfo files to update - By passing in rootDirectory as the first parameter, it will be able to find and update the correct attributes
(GH-59) Getting versioning working correctly
|
@JakeGinnivan figured out what the issue was here. GitVersion was being executed from within my BuildScripts folder, therefore there were no AssemblyInfo files downwind of that folder. Passed in the rootDirectory as the first parameter to GitVersion, and everything ended up working. Took me a minute to figure out what was going on though! |
|
Nice find |
|
@JakeGinnivan took me quite a while to figure it out, and at one point I was tearing out what little is left of my hair, but eventually it all became clear 😄 |
As seen here:
and here:
For the images shown above, it should be showing 0.3.0.
The text was updated successfully, but these errors were encountered: