Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-59) Getting versioning working correctly #74

Merged
merged 4 commits into from
Jan 8, 2016

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jan 2, 2016

No description provided.

- GitVersion was being executed from the BuildScripts folder, therefore
there were no AssemblyInfo files to update
- By passing in rootDirectory as the first parameter, it will be able to
find and update the correct attributes
@gep13
Copy link
Member Author

gep13 commented Jan 8, 2016

This is for #59

@gep13 gep13 changed the title [WIP] Getting versioning working correctly (GH-59) Getting versioning working correctly Jan 8, 2016
@gep13
Copy link
Member Author

gep13 commented Jan 8, 2016

Ended up doing a few more things that was necessary in this PR, but all for the greater good.

Updated to latest CommandLineParser, Fody, and NUnit.Console, as well as ultimately correcting the issue with the build script.

gep13 added a commit that referenced this pull request Jan 8, 2016
(GH-59) Getting versioning working correctly
@gep13 gep13 merged commit fe0f957 into GitTools:develop Jan 8, 2016
@gep13 gep13 deleted the Issue-59 branch January 8, 2016 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant