Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-188) Configure default labels #258

Merged
merged 4 commits into from
Jul 26, 2020
Merged

(GH-188) Configure default labels #258

merged 4 commits into from
Jul 26, 2020

Conversation

akordowski
Copy link
Contributor

This PR addresses #188.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2020

Codecov Report

Merging #258 into develop will increase coverage by 5.33%.
The diff coverage is 78.40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
+ Coverage    40.02%   45.36%   +5.33%     
===========================================
  Files           26       27       +1     
  Lines          732      798      +66     
  Branches       133      135       +2     
===========================================
+ Hits           293      362      +69     
+ Misses         421      418       -3     
  Partials        18       18              
Impacted Files Coverage Δ
Source/GitReleaseManager/GitHubProvider.cs 0.00% <0.00%> (ø)
Source/GitReleaseManager/Configuration/Config.cs 100.00% <100.00%> (ø)
...rce/GitReleaseManager/Configuration/LabelConfig.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c65fd...7d61711. Read the comment docs.

@gep13
Copy link
Member

gep13 commented Jul 26, 2020

@akordowski I have taken the liberty to rebase this PR against the latest head of the develop branch, and to remove some of the commits that you added.

There were already dependabot PR's open for bumping to the latest version of dependencies, so I have now merged those in, and the changes that you made are no longer requried.

In addition, as discussed on Gitter, I have updated your commit messages to use the suggested nomenclature, i.e. to include the GitHub issue number within the commit message.

We will now be able to review this PR, looking only at what has changed to implement the change associated with #188.

Let me know if you have any questions about the changes that I have made.

@akordowski
Copy link
Contributor Author

Looks good! I will keep in mind to use the issue number in the commit messages. Thanks!

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 1deaf3c into GitTools:develop Jul 26, 2020
@gep13
Copy link
Member

gep13 commented Jul 26, 2020

@akordowski your changes have been merged, thanks for your contribution 👍

gittools-bot pushed a commit that referenced this pull request Jul 26, 2020
Merge pull request #258 from akordowski/feature/GH-188-configure-default-labels

(GH-188) Configure default labels
@akordowski akordowski deleted the feature/GH-188-configure-default-labels branch July 27, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants