-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-188) Configure default labels #258
(GH-188) Configure default labels #258
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #258 +/- ##
===========================================
+ Coverage 40.02% 45.36% +5.33%
===========================================
Files 26 27 +1
Lines 732 798 +66
Branches 133 135 +2
===========================================
+ Hits 293 362 +69
+ Misses 421 418 -3
Partials 18 18
Continue to review full report at Codecov.
|
@akordowski I have taken the liberty to rebase this PR against the latest head of the develop branch, and to remove some of the commits that you added. There were already dependabot PR's open for bumping to the latest version of dependencies, so I have now merged those in, and the changes that you made are no longer requried. In addition, as discussed on Gitter, I have updated your commit messages to use the suggested nomenclature, i.e. to include the GitHub issue number within the commit message. We will now be able to review this PR, looking only at what has changed to implement the change associated with #188. Let me know if you have any questions about the changes that I have made. |
Looks good! I will keep in mind to use the issue number in the commit messages. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@akordowski your changes have been merged, thanks for your contribution 👍 |
This PR addresses #188.