-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ability to configure default labels #188
Comments
While testing the The default yaml config contains following labels:
the
which are not even consistent. I would like to suggest following implementation. Add a new section for the
Additionaly following labels could be added too:
I would like to implement the changes and provide a PR. |
@akordowski sorry, missed this update when going through things earlier. If you wanted to have a stab at implementing this, I would be more than happy to review a PR. Thanks |
Should I add all suggested labels or without the last three? |
@akordowski @gep13 I believe adding additional labels would be a separate enhancement request in additional to this feature request, and deserves its own issue. As such, for this specific issue only making the labels configurable but without adding any new ones would be appropriate IMO. |
So only the suggested? They contains the default GitHub labels plus |
I would say only
As these are the current defaults created by GRM: https://github.com/GitTools/GitReleaseManager/blob/develop/Source/GitReleaseManager/GitHubProvider.cs#L348-L356 Anything additional would be part of a new enhancement request. |
…ult-labels (GH-188) Configure default labels
@gep13 Issue can be closed. |
@akordowski agreed, thanks for following up on this one. |
🎉 This issue has been resolved in version 0.12.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Detailed Description
To remove the hard coded nature of the current implementation.
Context
Right now, the set of default labels that are used when executing the
label
command are hard coded into GRM. The values that were chosen were the ones that I use personally, but this isn't ideal. We need to provide the ability to configure what default labels are created when running thelabel
command.Possible Implementation
The default labels should be part of the configuration that can be added to the YAML file.
The text was updated successfully, but these errors were encountered: