Feature branch does not pick up version #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRose
reviewed
Nov 26, 2016
| @@ -22,7 +20,7 @@ public class BranchConfigurationCalculator | |||
| currentBranch.FriendlyName)); | |||
|
|
|||
| var branchConfig = new BranchConfig(); | |||
| ConfigurationProvider.ApplyBranchDefaults(config, branchConfig, ""); | |||
| ConfigurationProvider.ApplyBranchDefaults(config, branchConfig, "", isDevelop: true); | |||
There was a problem hiding this comment.
@JakeGinnivan This change is not needed anymore, at least with PR #1085.
There was a problem hiding this comment.
I removed that with my cleanup. This branch doesn't functionally change anything, it is more about the rename from is-develop to tracks-release-branches
JakeGinnivan
force-pushed
the
feature-branch-does-not-pick-up-version
branch
from
bd1fb1c
to
b0bd709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #1004 and some minor fixes