-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/di2 #1865
Feature/di2 #1865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one main question...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
be879e0
to
b13e926
Compare
I love the work you're doing here, @arturcic. Fantastic stuff! 👏 🎈 🎉 ❤️ |
@asbjornu, I have fixed the code as you suggested, will continue the work on adding DI. |
@asbjornu, I have fixed the code as you suggested |
@asbjornu, I have finished with the DI changes to the code, can you have a last review? Thanks in advance, I know there is a lot of code ;) |
I have addressed all the tasks in the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, @arturcic! 🙏 🎉 ❤️
src/GitVersionCore/SemanticVersioning/SemanticVersionFormatValues.cs
Outdated
Show resolved
Hide resolved
@asbjornu, I have applied the suggestions, so I guess the PR is more or less finished. I would prefer to address the remaining issues as part of other PRs, as I want to keep this PR for the introduction of DI and less for code refactorings. If you don't mind we can merge the code. What do you think? |
aa55262
to
112e0ca
Compare
@asbjornu I will merge the PR. I haave set it to be version 5.1.0-beta |
That's the continuation of the #1861
What was done: