Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Java 7 compilation flags #32

Closed

Conversation

asantibanez
Copy link

Java 8 is not fully supported in Android Studio when using features like Data Binding.

If a project uses Data Binding, Java 7 is the preferred compiler since Jack compiles (Java 8) does not behave well with Data Binding. If Java 7 is used, GitterJavaSDK cannot be included as a local module in another Android Project.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 14.53% when pulling 6680826 on asantibanez:feature/java-7-compilation into 8042b21 on Gitteroid:dev.

@amatkivskiy
Copy link
Member

@asantibanez Great work 👍 Thanks for fixing that.
The only thing is that the same changes persists in this PR #33 . So if I merge this PR you will need to resolve conflicts when merging #33 .
Or I can close this request and then merge only #33 . What do you think?

@asantibanez
Copy link
Author

Thanks @amatkivskiy. I think you can merge only #33. You are accepting both PRs, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants