Feature/rooms users extended search #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not add tests due to not understanding of setup of local mock server. I will be very happy to include tests. Can you point me in the right direction. Thanks? |
|
@asantibanez please see PR #34 . I've extracted common gitter request parameters to separate class so it can be used for any request. You can look on Chat Messages request as the example of passing params to the request |
|
@asantibanez Any updates on this? |
|
@asantibanez I am closing this PR as there is no activity for more than a year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Room/Users extended search parameters according to Gitter API.
Parameters Implemented as requested using an object to encapsulate parameters. Class name is RoomUsersRequestParams.
Implementation added for Sync, Async and Rx libraries.