Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored request params. #34

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Refactored request params. #34

merged 1 commit into from
Oct 18, 2016

Conversation

amatkivskiy
Copy link
Member

Extracted common request params so it will be possible to use them in other requests which accept this params (not only chat messages request).

Now @asantibanez you can use BasicRequestParams for the search room users request.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 14.53% when pulling 6c9e93f on feature/request-params-refactoring into 8042b21 on dev.

@amatkivskiy amatkivskiy mentioned this pull request Oct 18, 2016
Closed
@amatkivskiy amatkivskiy merged commit 9b6042a into dev Oct 18, 2016
@amatkivskiy amatkivskiy deleted the feature/request-params-refactoring branch October 18, 2016 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amatkivskiy @coveralls