-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare message for a decent D8 release. #39
Conversation
- Additional changes from SafeMarkup method removal. See https://www.drupal.org/node/2549395.
I think it would be better to break this to smaller PRs |
Sure. This PR just set up the basics. I'll open a follow up issues later on. |
@RoySegall issue title seems to no longer be correct? |
Check with the new html display we don't have xss when don't need to Make sure the view works similar to d7 1 A route with defined route name and path Fix the VBO integration(broken for now) Try to replace the current test in unit test/kernel base tests(similar to the work on http://github.com/amitaibu/og) I also added the following PRs which are pretty important for a stable release too I believe:
|
@mccrodp I can see you did some work on the PRs but the tests are still failing and not requested again the Let's start with a simple PR that fixing the tests and then go over the other PRs. |
@RoySegall / @jhedstrom - Ok, please see #46 re diff, then I can create a PR to address the tests. |
…ype in MessageUiTest.php
@RoySegall - Please check this PR: #47 - all tests are green again. |
Fix tests on update-travis branch
…ad of deprecated entityManager.
…late, removed title and label indexes / fields from template preprocess fn
Replace call to render function with use of render service
Make message twig template discoverable
@jhedstrom Can you handle #55? Then i'll merge it and close the PR. |
Add custom methods to the interfaces
OK. Most of the work is covered and this PR got very big. Merge this one and any other fix will be done in a follow PR. 10x for the work everyone! |
Prepare message for a decent D8 release.
I'm continuing @jhedstrom work. What left:
Once we got this we can have a first release for D8.