Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare message for a decent D8 release. #39

Merged
merged 47 commits into from
Feb 6, 2016
Merged

Conversation

RoySegall
Copy link

I'm continuing @jhedstrom work. What left:

  • Check with the new html display we don't have xss when don't need to
  • Make sure the view works similar to d7
  • Fix the VBO integration(broken for now)
  • Try to replace the current test in unit test/kernel base tests(similar to the work on http://github.com/amitaibu/og)
  • Fix tests

Once we got this we can have a first release for D8.

@amitaibu
Copy link
Member

I think it would be better to break this to smaller PRs

@RoySegall
Copy link
Author

Sure. This PR just set up the basics. I'll open a follow up issues later on.

@amitaibu
Copy link
Member

amitaibu commented Jan 5, 2016

@RoySegall issue title seems to no longer be correct?

@RoySegall RoySegall changed the title Update travis Prepare message for a decent D8 release. Jan 10, 2016
@RoySegall RoySegall mentioned this pull request Jan 10, 2016
@mccrodp
Copy link
Contributor

mccrodp commented Jan 11, 2016

Check with the new html display we don't have xss when don't need to
Not sure what is needed here or where this occurs in code / display

Make sure the view works similar to d7
Tried this again with no luck so far, see: #30
Any examples of this in contrib? i.e. -

1 A route with defined route name and path
2 A view with config overriding that exact path

Fix the VBO integration(broken for now)
Fixed this in PR: #44

Try to replace the current test in unit test/kernel base tests(similar to the work on http://github.com/amitaibu/og)
Not sure what is needed here either or what part of OG code is being referred to.

I also added the following PRs which are pretty important for a stable release too I believe:

@RoySegall
Copy link
Author

@mccrodp I can see you did some work on the PRs but the tests are still failing and not requested again the update-travis branch.

Let's start with a simple PR that fixing the tests and then go over the other PRs.

@mccrodp
Copy link
Contributor

mccrodp commented Jan 15, 2016

@RoySegall / @jhedstrom - Ok, please see #46 re diff, then I can create a PR to address the tests.

@mccrodp
Copy link
Contributor

mccrodp commented Jan 18, 2016

@RoySegall - Please check this PR: #47 - all tests are green again.

@jhedstrom
Copy link
Collaborator

Unless I'm missing something, #48 and #49 appear to be ready.

@RoySegall
Copy link
Author

@jhedstrom Can you handle #55? Then i'll merge it and close the PR.

@RoySegall
Copy link
Author

OK. Most of the work is covered and this PR got very big. Merge this one and any other fix will be done in a follow PR.

10x for the work everyone!

RoySegall pushed a commit that referenced this pull request Feb 6, 2016
Prepare message for a decent D8 release.
@RoySegall RoySegall merged commit 2d98ced into 8.x-1.x Feb 6, 2016
@jhedstrom jhedstrom deleted the update-travis branch March 12, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants