Surface view cache tags on subscription tabs. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jhedstrom
commented
Oct 31, 2016
jhedstrom
commented
- Fixes Caching issue on the Message Subscribe UI tabs #50
- Includes a test to demonstrate issue/fix.
amitaibu
reviewed
Oct 31, 2016
| $this->drupalGet('user/' . $users[3]->id() . '/message-subscribe'); | ||
| $this->assertSession()->pageTextContains(t('You are not subscribed to any items.')); | ||
| $flag = $this->flagService->getFlagById('subscribe_node'); | ||
| $this->flagService->flag($flag, $node, $users[3]); |
There was a problem hiding this comment.
maybe worth adding a comment that by seeing the node label, we confirm the Views cache is correct.
Rest looks good.
jhedstrom
force-pushed
the
50-cache-tags
branch
from
f994918
to
24710b9
Compare
|
(@jhedstrom I'm not with my computer, so can't push to d.o until the evening, so if you want to push, or wait for me ) |
|
Was pushed to d.o. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.