Signature of EventDispatcherInterface::dispatch() has changed #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Drupal 9.1 the order of the arguments to this method has been changed. Ref. https://www.drupal.org/node/3154407 Fixes #725.
|
This is failing on PHP 7.3 because it introduces typed properties which are PHP7.4+. Let's block this on #732 which increases our minimum PHP requirement to 7.4. |
|
Nice, the type hints that were added have uncovered some bugs in the I will handle this in a separate PR. |
|
@pfrenssen this is handler already in the D10 compatibility PR. This should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Drupal 9.1 the order of the arguments to this method has been changed.
Ref. Change record #3154407: Signature of EventDispatcherInterface::dispatch() has changed
Fixes #725.
This also updates the touched classes with modern practices, such as introducing missing type hints, and some small unrelated fixes.