Fixed #120: New member state is pending, should be active when added by admin

[alex-bukach]

No description provided.

[jcnventura]

Agree, admin should be able to promote to active directly.

[mmcintosh]

found this via the drupal issue queue. Just wanted to take a look and perhaps test as I have this problem on a site.

https://www.drupal.org/node/2744405

[mmcintosh]

I tested this code on OG 7.2.9 where I had the same issue as described in this issue:

https://www.drupal.org/node/2744405

I found the cope work as expected and now an administrator can add a user to a group and have it be active instead of pending. This was the behavior that was previously in place.

[amitaibu]

Seems there's a patch in https://www.drupal.org/node/2744405, so closing to prevent duplication.

[alex-bukach]

The patch posted there on d.o 3 days ago is the exactly the same I posted in this pull request in May? Why shouldn't it be committed?

[alex-bukach]

If "Development and issues are handled on GitHub" (as mentioned at https://www.drupal.org/project/og), why to close the pull request on Githuub in favour of the d.o issue?

[amitaibu]

Sorry, the reason was that currently there's the #133 which is blocking. you are right, I'll close the d.o. one.

The reason it's not committed is - https://www.drupal.org/node/2744405#comment-11735053

[geek-merlin]

The reason it's not committed is - https://www.drupal.org/node/2744405#comment-11735053

So the test failed, saying:

fail: [Other] Line 461 of sites/all/modules/og/og_access/og_access.test:
User membership is pending.

I did not go deeper into this, but it looks like the test must be changed too.
(maybe discerning admin role.)

[geek-merlin]

CI sais:

The command "pear channel-discover pear.drush.org" failed and exited with 1 during .

That's not a problem of the patch...

[amitaibu]

Thanks!

[jackaponte]

I don't see this commit in og 7.x-2.10 on drupal.org. Has it been fixed elsewhere now or was it just omitted?

I ran into the same question myself today while applying updates. This diff of the og-7.x-2.9 file in question against the 7.x-2.10 version seems to indicate that this commit/patch is no longer needed because the code affected by the patch is completely gone:

diff --git b/sites/all/modules/og/plugins/entityreference/behavior/OgBehaviorHandler.class.php a/sites/all/modules/og/plugins/entityreference/behavior/OgBehaviorHandler.class.php
index dc7373f7..d17a8e26 100644
--- b/sites/all/modules/og/plugins/entityreference/behavior/OgBehaviorHandler.class.php
+++ a/sites/all/modules/og/plugins/entityreference/behavior/OgBehaviorHandler.class.php
@@ -122,11 +122,7 @@ class OgBehaviorHandler extends EntityReference_BehaviorHandler_Abstract {
     foreach ($items as $item) {
       $gid = $item['target_id'];
 
-      // Must provide correct state in the event that approval is required.
-      if (empty($item['state']) && $entity_type == 'user' && !og_user_access($group_type, $gid, 'subscribe without approval', $entity) && !og_user_access($group_type, $gid, 'administer group')) {
-        $item['state'] = OG_STATE_PENDING;
-      }
-      elseif (empty($item['state']) || !in_array($gid, $diff['insert'])) {
+      if (empty($item['state']) || !in_array($gid, $diff['insert'])) {
         // State isn't provided, or not an "insert" operation.
         continue;
       }

(cross-posting to https://www.drupal.org/node/2744405)

[ghost]

@jackalope: I think you're right. It's been a month now and I'm seeing no problems.