Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options to spatialstats functions #218

Merged
merged 9 commits into from
Oct 1, 2021

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Sep 29, 2021

Some more flexibility for some spatialstats functions, without changing the default behaviour.

  • fit_sum_model_variogram can now take an inital guess of variogram parameters that are later passed to scipy.curve_fit: p0 and bounds bounds
  • plot_vgm can be passed xlabel, ylabel, xlim and ylim to more easily customize the plot (which can be hard with plt.gca()as the Figure is parted into subpanels within a grid)
  • fixed a bug in patches_method to allow for a "only 100% valid data" when checking patches no-data with the input threshold

For plots: it would be good to have a consistent approach at plotting and passing axes/grid objects to allow easy user edits without duplicating input parameters. But, realistically, this would have to be done in a later PR focusing on a plotting library. (skgstat plotting functionalitiers allow to pass ax, grid, and fig object back and forth, maybe we can check that out? or maybe there's better solutions out there, it's quite a common functionality people want to have)

@rhugonnet rhugonnet marked this pull request as draft September 29, 2021 12:37
@rhugonnet rhugonnet marked this pull request as ready for review October 1, 2021 11:39
@rhugonnet
Copy link
Contributor Author

@adehecq @erikmannerfelt
Ready to be merged, just a tiny bug fix and some more flexiblity in the fit/plot vgm functions.

@rhugonnet rhugonnet merged commit 71049ed into GlacioHack:main Oct 1, 2021
@rhugonnet rhugonnet deleted the spatialstats_flex branch October 1, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants