-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-users in Gladys Assistant #1050
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 95.45% 95.48% +0.02%
==========================================
Files 525 529 +4
Lines 6968 7036 +68
==========================================
+ Hits 6651 6718 +67
- Misses 317 318 +1
Continue to review full report at Codecov.
|
Will fix #637 |
To me, the PR is ready! See my message on the forum: https://community.gladysassistant.com/t/multi-utilisateurs/5510/24?u=pierre-gilles @VonOx @atrovato @cicoub13 @Terdious I'm interested in your review. Let me know what you think! |
* First views working * improve create user page * Improve design of user list * Fix bug when setting a new picture * disableRole in user own profile edit * Add get user by selector + delete user by selector * Add PATCH user route * Clean response of getBySelector/updateBySelector * edit user with get * Fix password update * make reset password work for admin user * Now possible to edit preferences * Dashboard are now private * It's now possible to delete a user * user shouldn't be able to delete his own account * Get user should be searchable & orderable * Fix edit user page * Fix tests & add more retrictions on routes (admin) * Fix tests * Hide settings for non-admin users * Add search and order to user list * Add FR translations * Fix eslint front * fix ui bugs * filter integrations for user with non admin role + hide scene * fix integration list bug * Hide weather + improve telegram integration * non admin user cannot create, update and delete scene * Fix demo mode * Save preferences in same form as user * Update dashboard selector in dashboard migration * UI improvements * Explain better what are roles * Set temperature/distance unit in create user too * Renforce admin securities on services * when creating account, role is not shown * Adapt Gladys plus to multi-users * Add loading bar for user screen
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Read more here: https://community.gladysassistant.com/t/multi-utilisateurs/5510/24?u=pierre-gilles