Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hours recur events #1367

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

bertrandda
Copy link
Contributor

@bertrandda bertrandda commented Nov 14, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix #1356
With timezone differences & DST I am confused 🤯 but it should fix recurring events time sifting.

PR also update CalDAV service dependencies

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #1367 (9cca81a) into master (9400ad9) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   96.60%   96.54%   -0.07%     
==========================================
  Files         613      613              
  Lines        8731     8735       +4     
==========================================
- Hits         8435     8433       -2     
- Misses        296      302       +6     
Impacted Files Coverage Δ
...services/caldav/lib/calendar/calendar.formaters.js 100.00% <100.00%> (ø)
server/utils/childProcess.js 66.66% <0.00%> (-33.34%) ⬇️
server/utils/functionsWrapper.js 71.42% <0.00%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9400ad9...9cca81a. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Looks good to me :)

Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@Pierre-Gilles Pierre-Gilles merged commit b6ab1c0 into GladysAssistant:master Nov 25, 2021
@relativeci
Copy link

relativeci bot commented Nov 25, 2021

Job #154: Bundle Size — 6.67MB (0%).

b6ab1c0 vs 9400ad9

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 0% 46.65%
Changed assets by type (0/7)

No changes


View Job #154 report on app.relative-ci.com

@bertrandda bertrandda deleted the fix/recur-events branch November 28, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong date for recurrent CalDav/Google event
3 participants